Build Ubuntu package #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that the plugin does install from this, but the background didn't become transparent - that could just be the quality of my mic - or the ML that it might be based on. But I'm glad that the package installed though! Blend just showed my webcam as normal (no transparent background), and mask was just all black so I couldn't even mask it. |
|
@norihiro Sorry for later reply. Thanks to your contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the packaging flow for Ubuntu.
/usr/lib/obs-virtualbg/by following obs-backgroundremoval in AUR. Even if another package uses a different version of ONNX runtime, it should not conflict.checkinstall. The code came from the previous obs-plugintemplateMITsince the plugin is released under MIT license.CMakeLists.txt,CMAKE_INSTALL_FULL_LIBDIRis not expanded to/usr/lib, I implemented another variableOBS_PLUGIN_DESTINATIONthat can be specified from cmake's command line.How it has been tested
OS: Ubuntu 20.04.3 LTS.
I ran this flow on Github Actions with my account, downloaded the package and installed to my Ubuntu machine on VirtualBox. And, I installed the package and confirmed the background becomes transparent.
Close #52.