New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagetree Macro and ReadMe.md update #329

Merged

mrueg merged 5 commits into kovetskiy:master from joyfulrabbit:pagetree

Jun 8, 2023

Contributor

joyfulrabbit commented Jun 7, 2023

No description provided.

joyfulrabbit added 3 commits

June 7, 2023 16:04


          page-tree

8f1d4ba


          readme

e9c75b3


          readme

f9737c9

joyfulrabbit mentioned this pull request

Question About Page Tree Macro #308

Closed

mrueg reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

mrueg reviewed

View reviewed changes

pkg/mark/stdlib/stdlib.go Outdated Show resolved Hide resolved

mrueg reviewed

View reviewed changes

pkg/mark/stdlib/stdlib.go Show resolved Hide resolved

mrueg reviewed

View reviewed changes

pkg/mark/stdlib/stdlib.go Show resolved Hide resolved

mrueg reviewed

View reviewed changes

pkg/mark/stdlib/stdlib.go Show resolved Hide resolved

mrueg reviewed

View reviewed changes

pkg/mark/stdlib/stdlib.go Show resolved Hide resolved

mrueg reviewed

View reviewed changes

pkg/mark/stdlib/stdlib.go Show resolved Hide resolved

mrueg reviewed

View reviewed changes

pkg/mark/stdlib/stdlib.go Show resolved Hide resolved

joyfulrabbit and others added 2 commits

June 8, 2023 09:42


          Update pkg/mark/stdlib/stdlib.go

51afb97

Co-authored-by: Manuel Rüger <[email protected]>


          Update README.md

bf992f3

Co-authored-by: Manuel Rüger <[email protected]>

Contributor Author

joyfulrabbit commented Jun 8, 2023 •

edited

Loading

Thanks for all the commentary, its really appreciated. I can probably do this for some other macros if there are enhancement requests. I'm slowly learning go and also using mark for a documentation project at my $(job) and so far they seem happy to pay me to work on it ;)

The code works as submitted on both cloud and on prem. No additional values are required to be set. I do think allowing them to be set is useful.

mrueg merged commit bec6d38 into kovetskiy:master

Collaborator

mrueg commented Jun 8, 2023

Fixed the failing unit test in another PR, so that should work.

Thanks for your contribution!

DreadPirateShawn mentioned this pull request

PageTree Macro: Root / Title is always "@self" and cannot be modified #550

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet