implement macros & includes #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovetskiy
reviewed
Aug 8, 2019
kovetskiy
reviewed
Aug 8, 2019
kovetskiy
reviewed
Aug 8, 2019
| } | ||
|
|
||
| creds, err := GetCredentials(args, config) | ||
| stdlib, err := stdlib.New(api) |
There was a problem hiding this comment.
can we do something less abstract? maybe longer name but more obvious about purposes of the package
There was a problem hiding this comment.
I can't come up with a better name. Do you have some variants in mind?
kovetskiy
reviewed
Aug 8, 2019
kovetskiy
reviewed
Aug 8, 2019
kovetskiy
reviewed
Aug 8, 2019
kovetskiy
reviewed
Aug 8, 2019
kovetskiy
reviewed
Aug 8, 2019
| `{{ else }}`, | ||
| /**/ `{{ .Body }}`, | ||
| `{{ end }}`, | ||
| ), |
There was a problem hiding this comment.
just a quick note: we could also store these templates in files and distribute them along with binary
There was a problem hiding this comment.
Yep, but on the other hand it will make tool not ready to use after go get/go install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.