Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Buffrs to 0.7.2 #58

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Update Buffrs to 0.7.2 #58

merged 2 commits into from
Dec 15, 2023

Conversation

mara-schulke
Copy link
Member

No description provided.

@mara-schulke mara-schulke self-assigned this Dec 6, 2023
@mara-schulke mara-schulke requested a review from Tpt December 6, 2023 10:56
Tpt
Tpt approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@Tpt Tpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that if you tag a new image with the current code, it will install Rust 1.74 that breaks Kraken auth system for Cargo.

@ntrinquier ntrinquier changed the title Update Buffrs Update Buffrs to 0.7.2 Dec 6, 2023
@ntrinquier
Copy link
Contributor

ntrinquier commented Dec 6, 2023 •
edited
Loading

Note that if you tag a new image with the current code, it will install Rust 1.74 that breaks Kraken auth system for Cargo.

This is a very good point, before tagging we should temporarily pin cargo's version here with an explanation.

@NiklasRosenstein
Copy link
Contributor

NiklasRosenstein commented Dec 15, 2023 •
edited
Loading

This should add support for Cargo 1.74 to Kraken: kraken-build/kraken#140

But we would still need to bump the base image version from 1.7.x to 1.8.x otherwise we break repos pinning on 1.7 (without patch). Let's pin Cargo to 1.73 for a while longer until we have more repositories on the latest version.

#62 pins the 1.73.0 toolchain

@helsing-ai-user helsing-ai-user merged commit aa1d64a into develop Dec 15, 2023
7 checks passed
@helsing-ai-user helsing-ai-user deleted the mara-schulke-patch-1 branch December 15, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tpt Tpt Tpt approved these changes

@NiklasRosenstein NiklasRosenstein Awaiting requested review from NiklasRosenstein

@ntrinquier ntrinquier Awaiting requested review from ntrinquier

Assignees

@mara-schulke mara-schulke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mara-schulke @ntrinquier @NiklasRosenstein @Tpt @helsing-ai-user