fix: Fixed an issue where when the DaemonController fails to start th…

…e daemon process, the fork of the Kraken process continues, resulting in two copies of the process trying to run to completion, e.g. executing tasks from this point on. (#218)

.changelog/_unreleased.toml

@@ -0,0 +1,5 @@
+[[entries]]
+id = "654174ac-b3d2-476a-b761-e65c8f4dd8a5"
+type = "fix"
+description = "Fixed an issue where when the DaemonController fails to start the daemon process, the fork of the Kraken process continues, resulting in two copies of the process trying to run to completion, e.g. executing tasks from this point on."
+author = "[email protected]"

kraken-build/src/kraken/std/util/daemon_controller.py

@@ -101,8 +101,10 @@ def spawn_fork(func: Callable[[], Any], detach: bool = True) -> int:
         return pid
     if detach:
         os.setsid()
-    func()
-    os._exit(os.EX_OK)
+    try:
+        func()
+    finally:
+        os._exit(os.EX_OK)
 
 
 def replace_stdio(stdin: int | None = None, stdout: int | None = None, stderr: int | None = None) -> None:
@@ -240,6 +242,7 @@ def start_daemon() -> None:
             state = self.State(command, str(cwd), env, proc.pid, time.time())
             self.save_state(state)
 
+        logger.debug("Spawning fork to start daemon %s", self.name)
         pid = spawn_fork(start_daemon)
         if status := wait_for_child_process(pid, 10.0):
             raise Exception("An unexpected error ocurred when starting daemon %r (exit code %s).", self.name, status)