Improve Windows support #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Robert-Krajewski-Helsing
commented
Jan 16, 2024
•
Robert-Krajewski-Helsing
commented
- Add support for pyenv-win
- Make subprocess calls for tasks work
- Avoid using dmypy due to non-zero exit code without any error message
Robert-Krajewski-Helsing
changed the title
There was a problem hiding this comment.
Thanks @Robert-Krajewski-Helsing ! Left a few comments. If you could also give this a changelog entry, this seems good to go!
| @@ -148,6 +148,13 @@ def get_candidates( | |||
| if re.match(r"\d+\.\d+\.\d+$", item.name) and item.is_dir(): | |||
| yield {"path": str(item / "bin" / "python"), "exact_version": item.name} | |||
|
|
|||
| # pyenv (Windows) | |||
| pyenv_versions = (Path(os.getenv('PYENV')) / "versions").expanduser() | |||
There was a problem hiding this comment.
Suggested change
| pyenv_versions = (Path(os.getenv('PYENV')) / "versions").expanduser() | |
| pyenv_versions = (Path(os.getenv("PYENV")) / "versions").expanduser() |
Black will complain about this
…PYENV` env-var and using the right `pyhon.exe` path on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.