Make Rust builds respect Cargo.lock when present #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kraken should, by default, respect the `Cargo.lock` present in the current Cargo project rather than silently pull down dependencies not explicitly noted in the initial `Cargo.lock`. This is accomplished by passing `--locked` to `cargo. If the lockfile is out of date, the underlying package should be updated to reflect that change if `Cargo.lock` is checked in. To avoid breaking existing workflows that don't check in `Cargo.lock`, the default behavior is to only pass `--locked` if a `Cargo.lock` exists in the parent directory tree of the current working directory. The flag only really matters to CargoBuildTask, CargoTestTask, and CargoMetadata, but is also propagated to CargoPublishTask so that it isn't allowed to silently update the lockfile if it happens to be called first. Clippy doesn't take `--locked`, and so remains unmodified. Note also that checking in `Cargo.lock` is now recommended by the Rust project: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
jonhoo
force-pushed
the
jon/locked-by-default
branch
from
d26eca6 to
cbaec4e
Compare
jonhoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kraken should, by default, respect the
Cargo.lockpresent in the current Cargo project rather than silently pull down dependencies not explicitly noted in the initialCargo.lock. If the lockfile is out of date, the underlying package should be updated to reflect that change ifCargo.lockis checked in.To avoid breaking existing workflows that don't check in
Cargo.lock, the default behavior is to only pass--lockedif aCargo.lockexists in the parent directory tree of the current working directory.The flag only really matters to CargoBuildTask, CargoTestTask, and CargoManifest, but is also propagated to CargoPublishTask so that it isn't allowed to silently update the lockfile if it happens to be called first. Clippy doesn't take
--locked, and so remains unmodified.Note also that checking in
Cargo.lockis now recommended by the Rust project: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html