Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend pytest task to accept sequence #284

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Extend pytest task to accept sequence #284

merged 5 commits into from
Sep 2, 2024

Conversation

sebimarkgraf
Copy link
Contributor

No description provided.

NiklasRosenstein
NiklasRosenstein reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@NiklasRosenstein NiklasRosenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you need to fix Mypy and formatting and I got one nit. 🙂

kraken-build/src/kraken/std/python/tasks/pytest_task.py Outdated Show resolved Hide resolved
NiklasRosenstein
NiklasRosenstein approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@NiklasRosenstein NiklasRosenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@NiklasRosenstein NiklasRosenstein merged commit 85fd678 into develop Sep 2, 2024
13 of 14 checks passed
@NiklasRosenstein NiklasRosenstein deleted the smossburger/pytest-accept-sequence branch September 2, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasRosenstein NiklasRosenstein NiklasRosenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kraken
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebimarkgraf @NiklasRosenstein