Add name check for basin id field #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also update the Wiki to include this information. |
gauchm
reviewed
Jun 2, 2022
Co-authored-by: Martin Gauch <[email protected]>
gauchm
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7, the problem was that the intersected polygons contains the fields/values of both shapefiles. In this case, the basin id field was present in the user shape file but also HydroATLAS (HYBAS_ID). This led to the problem that one intersected polygon had a HYBAS_ID that is not part of the
basin_idslist (which only contains the basins between the thresholds).In this PR I am adding a check that makes sure that the user specified BASIN_ID_FIELD is different to any HydroATLAS field.