Update libary to work with angular 2.2 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorsten
commented
Nov 16, 2016
thorsten
commented
- Update packages
- Update libary to work with changes
- Update tests
- Update packages - Update libary to work with changes - Update tests
- Call updateWithOptions only if options are updated. If data was changed only updateWithData will be called. - On updateWithData don't remove svg element if it already exists and just update the chart data, so the datachange can be animated.
Typings doesn't generate these files anymore in newer versions. Add 'es6' and 'dom' to lib in tsconfig instead.
Fix bug where the chart didn't on a a change in the options.
|
Thanks a lot! This is really big and great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.