Patch for class_weights #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ml_config, current dbt_ml code does not adequately support the 'class_weights' argument for models. This has to do with macros/materializations/model.sql line 29. The BigQuery ML specification for class weights requires an array of structs of key-value pairs to be passed in as a parameter (see here). In dbt, this needs to be passed as a string, as code will not compile with the word 'struct' and curly brace constructors are not supported. However, the current logic for string parameter handling, specifically the
| tojsondoes not work with structs. This simple patch allows for the following types of class weight calls for model creation: