Fixing model disk size evaluation for pvc #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckadner
force-pushed
the
Fixing-model-disk-size-evaluation-pvc
branch
from
42de9a1 to
ff48152
Compare
ckadner
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Thank you for this fix @GolanLevy -- Could you please fix the DCO check by signing off your commits?
https://github.com/kserve/modelmesh-runtime-adapter/pull/55/checks?check_run_id=17236997668
GolanLevy
force-pushed
the
Fixing-model-disk-size-evaluation-pvc
branch
from
389c210 to
ff48152
Compare
Signed-off-by: Golan Levy <[email protected]>
Signed-off-by: Golan Levy <[email protected]>
Signed-off-by: Golan Levy <[email protected]>
Signed-off-by: Golan Levy <[email protected]>
GolanLevy
force-pushed
the
Fixing-model-disk-size-evaluation-pvc
branch
from
ff48152 to
ac9e5e2
Compare
ckadner
approved these changes
Oct 2, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, GolanLevy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solving #54
Modifications
Resolved symlinks (created by PVC puller) in order to calculate the target's' size instead of the symlink's size.
Relevant tests were modified to validate the new behavior.
Result
Models' disk sizes (pulled from PVC) are evaluated correctly.