fix: Fix namespace-scoped install #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation There are some problems when installing in namespace-scoped mode: - Though the docs mentioned that the RBAC should be changed, the install script currently applies the controller ClusterRole and ClusterRoleBinding (including namespace resource permission) regardless of whether the --namespace-scope-mode option is provided - The combination of the NAMESPACE_SCOPE=true env var and namespace resource permissions results in a broken/conflicted state where the controller will "mostly" operate in cluster scoped mode and watch / delete resources in other namespaces Modifications - Split RBAC manifests into cluster-scope and namespace-scope variants, the latter including Role/RoleBinding instead of Cluster level equivalents - Have install script apply the appropriate RBAC based on the namespace-scope-mode cli setting (in addition to setting the controller env var as is already done) - Change the controller init logic to always use namespace mode if the env var is set - Update documentation accordingly Result Namespace scoped install works properly, won't touch any other namespaces Signed-off-by: Nick Hill <[email protected]>
scripts/delete.sh
Outdated
| # Determine whether a modelmesh-controller-rolebinding clusterrolebinding exists and is | ||
| # associated with the service account in this namespace. If not, don't delete the cluster level RBAC. | ||
| set +e | ||
| crb_ns=$(oc get clusterrolebinding modelmesh-controller-rolebinding -o json | jq -r .subjects[0].namespace) |
There was a problem hiding this comment.
Shall we stay with kubectl instead of oc?
There was a problem hiding this comment.
Thanks @chinhuang007 good catch, now fixed.
Signed-off-by: Nick Hill <[email protected]>
chinhuang007
approved these changes
Aug 20, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chinhuang007, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are some problems when installing in namespace-scoped mode:
ClusterRoleandClusterRoleBinding(including namespace resource permission) regardless of whether the--namespace-scope-modeoption is providedNAMESPACE_SCOPE=trueenv var and namespace resource permissions results in a broken/conflicted state where the controller will "mostly" operate in cluster scoped mode and watch / delete resources in other namespacesModifications
Role/RoleBindinginstead of Cluster level equivalentsResult
Namespace scoped install works properly, won't touch any other namespaces.
It would probably also be good to add some safeguard checks to detect/prohibit cluster scope installs in more than one namespace, but that's outside of the scope of this PR.