Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix port-forward command in run-inference.md #232

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Sep 8, 2022

Motivation

The code snippet to port-forward the modelmesh-serving service did not work:

$ kubectl port-forward modelmesh-serving 8033:8033

Error from server (NotFound): pods "modelmesh-serving" not found

Modifications

Update the code snippet to specify the resource type service:

$ kubectl port-forward service/modelmesh-serving 8033:8033

Result

Forwarding from 127.0.0.1:8033 -> 8033
Forwarding from [::1]:8033 -> 8033
Handling connection for 8033

/cc @njhill
/cc @chinhuang007

@ckadner ckadner added the documentation Improvements or additions to documentation label Sep 8, 2022
Copy link
Contributor

@chinhuang007 chinhuang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, @ckadner !

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chinhuang007, ckadner
To complete the pull request process, please assign animeshsingh after the PR has been reviewed.
You can assign the PR to them by writing /assign @animeshsingh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chinhuang007
Copy link
Contributor

/lgtm

@njhill
Copy link
Member

njhill commented Sep 9, 2022

/lgtm

@njhill
Copy link
Member

njhill commented Sep 9, 2022

Not sure why the bot isn't merging these... I'll do it manually.

@njhill njhill merged commit b70c186 into kserve:main Sep 9, 2022
@ckadner
Copy link
Member Author

ckadner commented Sep 9, 2022

Not sure why the bot isn't merging these... I'll do it manually.

I think the bot was waiting for both /lgtm and /approve labels. Your PRs automatically get the /approve labels as you are a project committer, so anyone reviewing your PRs only needs to add a /lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants