fix: Tolerate kustomize version 3.2 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes kserve#66 Signed-off-by: Christian Kadner <[email protected]>
|
/restest |
|
@njhill -- I seem to not have much luck with FVT tests :-) It does not seem to be related to my script changes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
Thanks @njhill |
ckadner
added a commit
to ckadner/modelmesh-serving
that referenced
this pull request
Sep 15, 2022
Until ModelMesh release 1.0 the Quickstart guide should require kustomize version 4.0.0 since the ModelMesh 0.9 release does not yet have the install script fixes (kserve#233) to tolerate older versions of the kustomize CLI. After ModelMesh release 1.0 the Quickstart should be changed to allow kustomize version 3.2.0 since that next release will include the respective install script fixes to tolerate older versions of kustomize. Fixes kserve#243 Signed-off-by: Christian Kadner <[email protected]>
kserve-oss-bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
#### Motivation Until ModelMesh release 1.0 the [Quickstart guide](https://github.com/kserve/modelmesh-serving/blob/main/docs/quickstart.md) should require `kustomize` version `4.0.0`+ since the ModelMesh 0.9 release does not yet have the [install script fixes](#233) to tolerate older versions of the `kustomize` CLI. After the ModelMesh 1.0 release, the Quickstart doc should be changed to allow `kustomize` version `3.2.0` since that next release will include the respective install script fixes (#233) to tolerate older versions of `kustomize`. Fixes #243 #### Modifications Reinstate the `kustomize` v`4.0.0`+ prereqs in the Quickstart guide. #### Result The required version of `kustomize` in the Quickstart guide matches what the install and delete scripts support. #### TODOs Create a new issue to change the Quickstart guide to allow `kustomize` version `3.2.0` after ModelMesh release `1.0` since that next release will include the respective install script fixes (#233) to tolerate older versions of `kustomize`. /cc @njhill @rafvasq Signed-off-by: Christian Kadner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Developers who work on both Kubeflow and ModelMesh must use different versions of the
kustomizeCLI as Kubeflow installation requires version no greater than3.2.0yet ModelMesh installation requires a version greater than4.0.0.There have been previous changes to the install scripts attempting to tolerate older
kustomizeversions, yet for3.2it is still causing errors like these:This is because various versions of
kustomizeproduce differently formatted output and the ModelMesh install scripts do not capture the intended semantic version identifier, i.e.Modifications
Change the install (and delete) scripts to
greponly the semantic version and use that to choose the correct install command syntax.Result
Installation (and de-installation) works for
kustomizeversions3.2.0up to latest (currently4.5.7)Related Issues:
Fixes #66