fix: Fix a couple of bugs for ClusterServingRuntime #257
Conversation
Fix a couple of bugs for ClusterServingRuntime and also rename two variables to reflect the cluster scope mode is enabled Signed-off-by: Chin Huang <[email protected]>
njhill
changed the title
Signed-off-by: Chin Huang <[email protected]>
There was a problem hiding this comment.
Thanks @chinhuang007 looks great, just one more small thing I just thought of.
Signed-off-by: Chin Huang <[email protected]>
chinhuang007
force-pushed
the
patch-csr-support
branch
from
4d3dd9c to
7d6902f
Compare
There was a problem hiding this comment.
Thanks @chinhuang007, LGTM now, I guess we just need to track down how this nil deref is happening...
Signed-off-by: Chin Huang <[email protected]>
There was a problem hiding this comment.
Thanks @chinhuang007, latest fix looks good, but can just always set the provided namespace.
|
@chinhuang007 incidentally I also noticed that setting a cluster-scoped owner here does nothing: https://github.com/manifestival/manifestival/blob/master/transform.go#L97-L100 which is unfortunate. I wonder whether that statement about it being broken is still true (it's pretty old). The Kube docs don't mention anything about it. |
Signed-off-by: Chin Huang <[email protected]>
|
It seems a bit odd that doc says " Namespaced dependents can specify cluster-scoped or namespaced owners." but the manifestival transform code does nothing to cluster-scoped owners. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chinhuang007, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
FWIW I opened an issue in the manifestival repo to ask about this: manifestival/manifestival#90 |
Fix a couple of bugs for ClusterServingRuntime and also rename two variables to reflect the cluster scope mode is enabled
Signed-off-by: Chin Huang [email protected]
Motivation
Fix bugs and make code more readable