-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Ensure CRD inline code consistency #265
Conversation
@rafvasq Thanks for the fixes! Can you run |
Signed-off-by: Rafael Vasquez <[email protected]>
@chinhuang007 Thanks for the reminder, I've run it. No more lint issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rafvasq
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chinhuang007, njhill, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Motivation
Reading through the docs, I noticed that the majority of references to CRDs used inline code (e.g.
InferenceService
,InferenceService
s,InferenceService
's) but in many instances inline code blocks weren't used, sometimes within the same document.Modifications
Updated references to
ServingRuntime
s orInferenceService
s to use inline code blocks for consistency along with a couple of typo fixes.Result
Consistent references to CRDs and less confusion to the reader.