-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update makefile to support building with podman #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anishasthana, this looks good to me. I thought docker
aliased to podman
anyhow though?
Should we also add --format=docker
to the build
command in the podman case?
Signed-off-by: Anish Asthana <[email protected]>
It only happens if you've actually set up the alias ahead of time. I hadn't :-)
I actually haven't used the |
I spoke to one of the podman maintainers. She said that the |
Ah interesting, the RHEL install I use had it already so I assumed it was configured by default.
OK sure, I just recall that I'd had to add it at some point in the past, maybe was for something obscure. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This PR will update the makefile and build scripts to allow developers to use podman as the build engine.
The default behaviour for the makefile will remain the same.
I ran the following to build images:
I don't have a working docker env to test in.
cc @njhill