Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update quickstart to include ovms #270

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Oct 27, 2022

Motivation

Output in the Quickstart documentation doesn't capture all three ServingRuntimes. Potentially just missed in #167.

Modifications

Update output and supported frameworks to include OpenVINO.

Result

More accurate documentation for new users.

Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq requested review from chinhuang007 and removed request for Tomcli October 27, 2022 14:23
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @rafvasq

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhill, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njhill
Copy link
Member

njhill commented Oct 27, 2022

/lgtm

@kserve-oss-bot kserve-oss-bot merged commit a0ee23f into kserve:main Oct 27, 2022
@rafvasq rafvasq deleted the quickstart-fix branch October 27, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants