-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support passing labels and annotations from ServingRuntimePodSpec to runtime Pod #271
feat: Support passing labels and annotations from ServingRuntimePodSpec to runtime Pod #271
Conversation
Hi @njhill , there are some issues after upgrading the dependencies to go 1.18 which is required by the latest kserve. lint was failed for the components in |
b8f17fa
to
ac8077b
Compare
Issue was fixed after I updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lizzzcai, these changes look great!
Do you think you could rebase since another merged PR made equivalent changes to the CRD manifests, then I'll merge this.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lizzzcai, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Lize Cai <[email protected]>
Signed-off-by: Lize Cai <[email protected]>
Signed-off-by: Lize Cai <[email protected]>
Signed-off-by: Lize Cai <[email protected]>
Signed-off-by: Lize Cai <[email protected]>
dc16d14
to
a0865e2
Compare
Thanks again @lizzzcai |
/lgtm |
Motivation
fix #224
Modifications
ServingRuntimePodSpec
todeployment.Spec.Template
and add testsResult
The feature is functionally working, I have tested it manually.
The user is able to pass labels and annotations from servingruntime. It will overwrite labels and annotations from the config.