Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support passing labels and annotations from ServingRuntimePodSpec to runtime Pod #271

Merged
merged 5 commits into from
Nov 3, 2022

Conversation

lizzzcai
Copy link
Member

@lizzzcai lizzzcai commented Oct 27, 2022

Motivation

fix #224

Modifications

  1. Update servingruntime CRDs
  2. pass labels and annotations from ServingRuntimePodSpec to deployment.Spec.Template and add tests
  3. upgrade dependencies

Result

The feature is functionally working, I have tested it manually.
The user is able to pass labels and annotations from servingruntime. It will overwrite labels and annotations from the config.

@lizzzcai
Copy link
Member Author

Hi @njhill , there are some issues after upgrading the dependencies to go 1.18 which is required by the latest kserve. lint was failed for the components in fvt, can you help to take a look, Thanks.

@lizzzcai lizzzcai force-pushed the feat-sr-add-labels-annotations-1025 branch from b8f17fa to ac8077b Compare October 27, 2022 18:16
@lizzzcai
Copy link
Member Author

Hi @njhill , there are some issues after upgrading the dependencies to go 1.18 which is required by the latest kserve. lint was failed for the components in fvt, can you help to take a look, Thanks.

Issue was fixed after I updated the go.mod, so the PR is ready for review.

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizzzcai, these changes look great!

Do you think you could rebase since another merged PR made equivalent changes to the CRD manifests, then I'll merge this.

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizzzcai, njhill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lizzzcai lizzzcai force-pushed the feat-sr-add-labels-annotations-1025 branch from dc16d14 to a0865e2 Compare November 2, 2022 16:51
@lizzzcai
Copy link
Member Author

lizzzcai commented Nov 2, 2022

Thanks @lizzzcai, these changes look great!

Do you think you could rebase since another merged PR made equivalent changes to the CRD manifests, then I'll merge this.

Hi @njhill , done.

@njhill
Copy link
Member

njhill commented Nov 2, 2022

Thanks again @lizzzcai

@njhill
Copy link
Member

njhill commented Nov 2, 2022

/lgtm

@njhill njhill merged commit 1d516e7 into kserve:main Nov 3, 2022
@lizzzcai lizzzcai deleted the feat-sr-add-labels-annotations-1025 branch November 6, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support passing labels and annotations in ServingRuntime to runtime Pod
3 participants