Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Custom Runtime Docs #277

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Nov 10, 2022

Motivation

While creating a Python-based custom runtime, I found that some of the documentation and templates could be a bit more helpful with naming conventions, hints, and formatting to match the MLServer built-in runtime for ease of comparison.

Modifications

Copy-edited docs while adding help and clarification to templates.

Result

Friendlier documentation for building and deploying custom runtimes.

@rafvasq rafvasq added the documentation Improvements or additions to documentation label Nov 10, 2022
@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rafvasq
To complete the pull request process, please assign animeshsingh after the PR has been reviewed.
You can assign the PR to them by writing /assign @animeshsingh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Rafael Vasquez <[email protected]>
Copy link
Contributor

@chinhuang007 chinhuang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @rafvasq !

@chinhuang007
Copy link
Contributor

/lgtm

@rafvasq rafvasq added approved and removed approved labels Nov 16, 2022
@njhill
Copy link
Member

njhill commented Nov 16, 2022

/lgtm

@njhill njhill merged commit 1bb590d into kserve:main Nov 16, 2022
@rafvasq rafvasq deleted the custom-runtime-fix branch November 17, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants