Fix FVT runtime count issue #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckadner
reviewed
Nov 30, 2022
chinhuang007
force-pushed
the
fix-fvt-runtime-count
branch
from
bf40ad4 to
74e0e45
Compare
Fix FVT runtime count issue by making torchserve as cluster serving runtime as default, similar to other out-of-the-box runtimes Signed-off-by: Chin Huang <[email protected]>
chinhuang007
force-pushed
the
fix-fvt-runtime-count
branch
from
74e0e45 to
b12b93e
Compare
|
/assign @njhill |
rafvasq
approved these changes
Dec 1, 2022
|
@njhill -- when you get a chance, please add your |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chinhuang007, ckadner, njhill, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix FVT runtime count issue by making torchserve as cluster serving runtime as default, similar to other out-of-the-box runtimes
Signed-off-by: Chin Huang [email protected]
Motivation
Make FVT working in the default cluster scoped mode
Modifications
Change torchserve-0.x to be a ClusterRuntime
Add a line to e2e FVT to disable torchserve-0.x, similar to github actions
Result
FVT working in cluster scoped mode
e2e working