Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile packages #291

Merged
merged 4 commits into from
Jan 6, 2023

Conversation

JasmondL
Copy link
Contributor

Motivation

Fix vulnerabilities in the ModelMesh Controller image.

Modifications

  1. Remove dependencies to any packages in the runtime.
  2. Updated Go version to the latest version.

Result

The feature is functionally working, I have tested it on my own cluster.

Signed-off-by: JasmondL <[email protected]>
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JasmondL -- I have a few questions, comments :-)

Dockerfile Outdated Show resolved Hide resolved
Dockerfile.develop Show resolved Hide resolved
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more comments after chatting with @njhill

go.mod Outdated Show resolved Hide resolved
Dockerfile.develop Show resolved Hide resolved
Dockerfile.develop Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@ckadner ckadner requested review from ckadner and removed request for tedhtchang December 13, 2022 21:56
@JasmondL JasmondL force-pushed the fix/docker-vulnerability branch from 208bc34 to 72966ac Compare December 14, 2022 09:33
go.mod Outdated Show resolved Hide resolved
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ckadner
Copy link
Member

ckadner commented Dec 15, 2022

Thanks @JasmondL -- this looks good now!

/cc @njhill

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, JasmondL, njhill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njhill
Copy link
Member

njhill commented Jan 6, 2023

/lgtm

@kserve-oss-bot kserve-oss-bot merged commit 6ad067c into kserve:main Jan 6, 2023
njhill pushed a commit that referenced this pull request Jan 8, 2023
#### Motivation
Fix vulnerabilities in the ModelMesh Controller image.

#### Modifications
1. Remove dependencies to any packages in the runtime. 
2. Updated Go version to the latest version.

#### Result 
The feature is functionally working, I have tested it on my own cluster.

Signed-off-by: JasmondL <[email protected]>

Co-authored-by: JasmondL <[email protected]>
Co-authored-by: Jasmond L <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants