Use --namespace-scope-mode for Quickstart
#304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Kadner <[email protected]>
njhill
approved these changes
Jan 10, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
njhill
pushed a commit
that referenced
this pull request
Jan 10, 2023
#### Motivation Quickstart should use namespace scope mode for simplicity. In current version there is an inconsistency wrt `ServingRuntimes` vs `ClusterServingRuntimes`. #### Modifications - `docs/install/install-script.md` (correct a typo) - `docs/quickstart.md` (change install command for ns scope mode and add missing `torchserv` serving runtime) - `scripts/install.sh` (fix `sed -i` commands) #### Result Quickstart install steps work like a charm again :-) #### TODOs Once merged into `main`, we will need to update the `release-0.10` branch as well --- /cc @njhill /assign @njhill Signed-off-by: Christian Kadner <[email protected]> (cherry picked from commit fbd8c62)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Quickstart should use namespace scope mode for simplicity. In current version there is an inconsistency wrt
ServingRuntimesvsClusterServingRuntimes.Modifications
docs/install/install-script.md(correct a typo)docs/quickstart.md(change install command for ns scope mode and add missingtorchservserving runtime)scripts/install.sh(fixsed -icommands)Result
Quickstart install steps work like a charm again :-)
TODOs
Once merged into
main, we will need to update therelease-0.10branch as well/cc @njhill
/assign @njhill