Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: include namespace-scope info #306

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Jan 10, 2023

Motivation

There doesn't seem to be much information about what the --namespace-scope-mode flag does, or the difference between cluster-scoped and namespace-scoped serving runtimes.

Modifications

  • As a start, a blurb is included for the --namespace-scope-mode flag in the install-script doc.
  • Corrects the --help output as well.

Result

Helpful information about the --namespace-scope-mode which is included in the recommended way to use the quick-start install of ModelMesh.

@rafvasq rafvasq added the documentation Improvements or additions to documentation label Jan 10, 2023
@rafvasq rafvasq requested review from ckadner and njhill January 10, 2023 18:56
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafvasq!

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhill, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njhill
Copy link
Member

njhill commented Jan 18, 2023

/lgtm

@kserve-oss-bot kserve-oss-bot merged commit 8c68e3f into kserve:main Jan 18, 2023
@rafvasq rafvasq deleted the fix-install-doc branch January 19, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved documentation Improvements or additions to documentation lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants