docs: Update release process #307

ckadner · 2023-01-11T01:02:38Z

Proposed Changes

Elaborate the steps in the release process.

https://github.com/ckadner/modelmesh-serving/blob/update-release-process-doc/docs/release-process.md

Updates since last review:

Signed-off-by: Christian Kadner <[email protected]>

njhill

Thanks @ckadner these look really good. Just had a couple of minor comments

njhill · 2023-01-13T19:41:03Z

release/RELEASE_PROCESS.md

-1.  They simplify back porting critical bug fixes to a patch level release for a particular release stream (e.g., producing a `v0.6.1` from `release-0.6`), when appropriate.
+1. They allow a release wrangler or other developers to focus on a release without interrupting development on `main`,
+2. They allow developers to track the development of a release before a release candidate is declared,
+3. They simplify back porting critical bug fixes to a patch level release for a particular release stream (e.g., producing a `v0.6.1` from `release-0.6`), when appropriate.


nit: Any reason for changing the numbering here (same applies to below)?

you mean we should use 0.10 as an example or how we utilize Mardown numbering here?

release/RELEASE_PROCESS.md

njhill · 2023-01-13T19:47:57Z

release/RELEASE_PROCESS.md

+11. Compare the release and release artifacts to those of previous releases to make
+    sure nothing was missed. Verify that the newly released version of the
+    [`modelmesh-controller`](https://hub.docker.com/r/kserve/modelmesh-controller/tags)
+    was pushed to DockerHub.


Should we mention anything about testing / checking fvt results?

yup -- my running list:

FVT, test -- verify the "check" results on last pushed tag

update KServe ... website, charts (more details to be gathered)

work with Dan on a relase blog

rafvasq

Just leaving a few proofreading-related comments! Thanks Christian.

release/RELEASE_PROCESS.md

Signed-off-by: Christian Kadner <[email protected]>

ckadner · 2023-02-17T17:54:30Z

Thanks for your review @rafvasq -- I addressed your comments and added the post-release section including the step about working with Dan on a release blog. If you have further guidance on that, please advice :-)

Signed-off-by: Christian Kadner <[email protected]>

rafvasq

Thanks Christian, just a few nits and a question about where FVTs fits in to all of this.

Re: the release blog and collaboration with Dan, I think you captured it fine. I ended up simply providing the ModelMesh portion of the blog to him via a review.

rafvasq · 2023-02-17T18:43:57Z

docs/release-process.md

+   action to push the respective (pre-)release container images to DockerHub which
+   are needed in the next step.
+
+2. Verify image tags got pushed to [DockerHub](https://hub.docker.com/u/kserve):


nit: "were pushed"

rafvasq · 2023-02-17T19:46:28Z

docs/release-process.md

+
+## Release Blog
+
+If possible work with [Dan Sun](https://kubeflow.slack.com/archives/D04PVPHMN8K)


nit: "If possible, work with" (comma)

rafvasq · 2023-02-17T19:47:33Z

docs/release-process.md

+
+## Update the KServe Website
+
+In the `kserve/website` repository update all reference to the previous ModelMesh


nit: "In the kserve/website repository, update" (comma)

docs/release-process.md

Signed-off-by: Christian Kadner <[email protected]>

ckadner · 2023-02-17T20:52:56Z

Thank you for your detailed review @rafvasq -- I pushed another update addressing your comments

rafvasq

Thanks @ckadner, I left a link to v.10's blog but think there are enough examples and linking to the PR draft like you did is helpful too. Up to you if you want to include it too. Otherwise LGTM :)

rafvasq · 2023-02-21T18:36:40Z

docs/release-process.md

+- [v0.7.0](https://kserve.github.io/website/blog/articles/2021-10-11-KServe-0.7-release)
+- [v0.8.0](https://kserve.github.io/website/0.8/blog/articles/2022-02-18-KServe-0.8-release/#modelmesh-updates)
+- [v0.9.0](https://kserve.github.io/website/0.9/blog/articles/2022-07-21-KServe-0.9-release/#inferenceservice-api-for-modelmesh)
+- [v0.10.0 draft](https://github.com/kserve/website/pull/227#discussion_r1098917277)


FYI, v0.10's blog has now been released.

njhill · 2023-02-22T10:40:28Z

Thanks @ckadner!

njhill · 2023-02-22T10:40:37Z

/lgtm

kserve-oss-bot · 2023-02-22T10:42:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, njhill, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [njhill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Update RELEASE_PROCESS.md

e1a70bc

Signed-off-by: Christian Kadner <[email protected]>

kserve-oss-bot requested review from njhill and rafvasq January 11, 2023 01:02

ckadner marked this pull request as draft January 11, 2023 01:02

kserve-oss-bot added the do-not-merge/work-in-progress label Jan 11, 2023

ckadner self-assigned this Jan 11, 2023

ckadner added the documentation Improvements or additions to documentation label Jan 11, 2023

ckadner changed the title ~~Update RELEASE_PROCESS.md~~ docs: Update RELEASE_PROCESS.md Jan 11, 2023

ckadner added 7 commits January 10, 2023 17:19

Fix formatting

9d22614

Signed-off-by: Christian Kadner <[email protected]>

Order bullets in section 3 alphabetically

fe43201

Formatting changes

a0d9034

Add more bullets for easy checklisting

894334b

Auto-detect tar command and release version

c3a0f20

Signed-off-by: Christian Kadner <[email protected]>

Reformat code blocks

920ab5e

Signed-off-by: Christian Kadner <[email protected]>

BSD tar should equivalent folder structure

27ff162

Signed-off-by: Christian Kadner <[email protected]>

ckadner changed the title ~~docs: Update RELEASE_PROCESS.md~~ docs: Update RELEASE_PROCESS.md Jan 11, 2023

ckadner marked this pull request as ready for review January 11, 2023 04:51

kserve-oss-bot removed the do-not-merge/work-in-progress label Jan 11, 2023

ckadner assigned njhill and unassigned ckadner Jan 11, 2023

ckadner added 7 commits January 10, 2023 22:06

Verify images got pushed to DockerHub

69078c1

Signed-off-by: Christian Kadner <[email protected]>

Update checkboxes

8f68f5b

Minor text update and issue link refinement

00de411

Require kustomize version 4.x

53f5653

Print link to create new release from pushed tag

81e3c79

Elaborate final release step

7011769

Update last release verification step

d69b913

ckadner marked this pull request as draft January 12, 2023 19:45

kserve-oss-bot added the do-not-merge/work-in-progress label Jan 12, 2023

njhill reviewed Jan 13, 2023

View reviewed changes

rafvasq reviewed Jan 13, 2023

View reviewed changes

ckadner unassigned njhill Jan 20, 2023

Move to docs/release-process.md

5fd2a12

Signed-off-by: Christian Kadner <[email protected]>

ckadner self-assigned this Feb 16, 2023

Address review comments

741c021

Signed-off-by: Christian Kadner <[email protected]>

kserve deleted a comment from kserve-oss-bot Feb 16, 2023

ckadner added 2 commits February 15, 2023 20:47

Add section for release preparation

faa1755

Signed-off-by: Christian Kadner <[email protected]>

Add section for updates to KServe

299e555

Signed-off-by: Christian Kadner <[email protected]>

ckadner marked this pull request as ready for review February 16, 2023 06:22

kserve-oss-bot removed the do-not-merge/work-in-progress label Feb 16, 2023

ckadner requested review from njhill and rafvasq February 16, 2023 06:22

kserve deleted a comment from kserve-oss-bot Feb 16, 2023

ckadner changed the title ~~docs: Update RELEASE_PROCESS.md~~ docs: Update release process Feb 16, 2023

ckadner added 3 commits February 17, 2023 10:33

Fix small wording kerfuffle

c07ef46

Signed-off-by: Christian Kadner <[email protected]>

Add a note on pre-releasing

aa711d6

Signed-off-by: Christian Kadner <[email protected]>

Fix another wording mumbo-jumbo

963b111

Signed-off-by: Christian Kadner <[email protected]>

rafvasq reviewed Feb 17, 2023

View reviewed changes

Address review comments

dfb525a

Signed-off-by: Christian Kadner <[email protected]>

rafvasq approved these changes Feb 21, 2023

View reviewed changes

kserve-oss-bot assigned njhill Feb 22, 2023

kserve-oss-bot added the lgtm label Feb 22, 2023

njhill approved these changes Feb 22, 2023

View reviewed changes

kserve-oss-bot added the approved label Feb 22, 2023

kserve-oss-bot merged commit bf412be into kserve:main Feb 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Update release process #307

docs: Update release process #307

ckadner commented Jan 11, 2023 •

edited

Loading

njhill left a comment

njhill Jan 13, 2023

ckadner Jan 13, 2023

njhill Jan 13, 2023

ckadner Jan 13, 2023

rafvasq left a comment

ckadner commented Feb 17, 2023

rafvasq left a comment

rafvasq Feb 17, 2023

rafvasq Feb 17, 2023

rafvasq Feb 17, 2023

ckadner commented Feb 17, 2023

rafvasq left a comment

rafvasq Feb 21, 2023

njhill commented Feb 22, 2023

njhill commented Feb 22, 2023

kserve-oss-bot commented Feb 22, 2023


		## Release Blog

		If possible work with [Dan Sun](https://kubeflow.slack.com/archives/D04PVPHMN8K)


		## Update the KServe Website

		In the `kserve/website` repository update all reference to the previous ModelMesh

docs: Update release process #307

docs: Update release process #307

Conversation

ckadner commented Jan 11, 2023 • edited Loading

Proposed Changes

Updates since last review:

njhill left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafvasq left a comment

Choose a reason for hiding this comment

ckadner commented Feb 17, 2023

rafvasq left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ckadner commented Feb 17, 2023

rafvasq left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

njhill commented Feb 22, 2023

njhill commented Feb 22, 2023

kserve-oss-bot commented Feb 22, 2023

ckadner commented Jan 11, 2023 •

edited

Loading