fix: etcd pod fails to start on OpenShift #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves kserve#210 Resolves kserve#215 Signed-off-by: Christian Kadner <[email protected]>
ckadner
requested review from
rafvasq
and removed request for
pvaneck and
chinhuang007
njhill
approved these changes
Feb 1, 2023
config/dependencies/quickstart.yaml
Outdated
| @@ -43,6 +43,8 @@ spec: | |||
| containers: | |||
| - command: | |||
| - etcd | |||
| - --data-dir | |||
There was a problem hiding this comment.
Just a small thing but might be nice to add a short comment here explaining why it's done
There was a problem hiding this comment.
How about this 148a7a4
- command:
- etcd
- --data-dir # use data directory under /tmp for read/write access by non-root user on OpenShift
- /tmp/etcd.dataSigned-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
njhill
approved these changes
Feb 2, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
njhill
pushed a commit
that referenced
this pull request
Feb 2, 2023
#### Motivation Addressing file access permission issues on OpenShift reported in issues #210 and #215 for the `etcd` deployment. #### Modifications Adding `data-dir` parameter to the container `args`: ``` - --data-dir - /tmp/etcd.data ``` #### Result The `etcd` pod comes up fine and spot-testing a few basic use cases went fine. I tested on IBM Cloud Kubernetes 1.24 and OCP 4.10 --- Resolves #210 Resolves #215 Signed-off-by: Christian Kadner <[email protected]> (cherry picked from commit f2a4a30)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addressing file access permission issues on OpenShift reported in issues #210 and #215 for the
etcddeployment.Modifications
Adding
data-dirparameter to the containerargs:Result
The
etcdpod comes up fine and spot-testing a few basic use cases went fine. I tested on IBM Cloud Kubernetes 1.24 and OCP 4.10Resolves #210
Resolves #215