Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Generalizes sed and fixes dry-run cmd #363

Merged
merged 2 commits into from
May 3, 2023
Merged

fix: Generalizes sed and fixes dry-run cmd #363

merged 2 commits into from
May 3, 2023

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented May 1, 2023 •
edited
Loading

Motivation

I experienced a few errors when running the install script using the --enable-self-signed-ca flag from the recently merged #342.

Modifications

  • Use sed -i.bak to work around different versions of it, originally resulting in sed: -i: No such file or directory for me.
  • Fix --dry-run error which requires a set value (none, server, or client)
  • Fix typos

Result

Fixes errors associated with the --enable-self-signed-ca flag

@rafvasq rafvasq added the bug Something isn't working label May 1, 2023
@rafvasq rafvasq requested a review from Jooho May 1, 2023 16:48
@rafvasq rafvasq changed the title Fix: Generalizes sed and fixes dry-run cmd fix: Generalizes sed and fixes dry-run cmd May 1, 2023
ckadner
ckadner previously approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ckadner
Copy link
Member

ckadner commented May 2, 2023

Thanks for this fix @rafvasq -- Looks good. Any reason this is marked as a draft?

@rafvasq rafvasq marked this pull request as ready for review May 2, 2023 13:20
@rafvasq
Copy link
Member Author

rafvasq commented May 2, 2023

Thanks for this fix @rafvasq -- Looks good. Any reason this is marked as a draft?

Thanks @ckadner. I had marked it as draft because there was another potential bug I wanted to work out and include in this PR, but we could just open up another PR when we have the fix for that. Marking this ready for now.

@Jooho
Copy link
Contributor

Jooho commented May 2, 2023

/lgtm

@ckadner
Copy link
Member

ckadner commented May 2, 2023

@Jooho -- the other error

webhook-server.default": failed to call webhook: Post "https://modelmesh-webhook-server-service.modelmesh-serving.svc:9443/validate-serving-modelmesh-io-v1alpha1-servingruntime?timeout=10s": EOF

tjohnson31415
tjohnson31415 reviewed May 2, 2023
View reviewed changes
scripts/install.sh Outdated Show resolved Hide resolved
@rafvasq
Update line to delete patch
65a749d 
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq
Copy link
Member Author

rafvasq commented May 3, 2023 •
edited
Loading

@ckadner

webhook-server.default": failed to call webhook: Post "https://modelmesh-webhook-server-service.modelmesh-serving.svc:9443/validate-serving-modelmesh-io-v1alpha1-servingruntime?timeout=10s": EOF

No longer experiencing this one! Controller is coming up with the webhook configured as expected :)

@rafvasq rafvasq requested review from Jooho, tjohnson31415 and ckadner May 3, 2023 16:02
@tjohnson31415
Copy link
Contributor

tjohnson31415 commented May 3, 2023 •
edited
Loading

/lgtm

@tjohnson31415
Copy link
Contributor

/approve

tjohnson31415
tjohnson31415 approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@tjohnson31415 tjohnson31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ckadner
ckadner approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq, tjohnson31415

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit 4746079 into kserve:main May 3, 2023
@rafvasq rafvasq deleted the fix-self-signed branch May 3, 2023 21:52
Jooho added a commit to Jooho/modelmesh-serving that referenced this pull request May 5, 2023
@Jooho
Sync with kserve/modelmesh(2023.05.04)-kserve#342,kserve#354,kserve#363
198454a 
Signed-off-by: jooho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckadner ckadner ckadner approved these changes

@tjohnson31415 tjohnson31415 tjohnson31415 approved these changes

@njhill njhill Awaiting requested review from njhill

@Jooho Jooho Awaiting requested review from Jooho

Assignees

@Jooho Jooho

@tjohnson31415 tjohnson31415

@ckadner ckadner

Labels
approved bug Something isn't working lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rafvasq @ckadner @Jooho @tjohnson31415 @kserve-oss-bot