Support ARM 64 bit architecture

[ckadner]

Issue Addressed by this PR

Quickstart deployment of an InferenceService fails on Macs with M1 chip. The modelmesh-serving-mlserver-0.x pod does not deploy because of an affinity restriction to amd64.

Events:
  Type     Reason            Age   From               Message
  ----     ------            ----  ----               -------
  Warning  FailedScheduling  17s   default-scheduler  0/1 nodes are available: 1 node(s) didn't match Pod's node affinity/selector. preemption: 0/1 nodes are available: 1 Preemption is not helpful for scheduling.

      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
            - matchExpressions:
              - key: kubernetes.io/arch
                operator: In
                values:
                - amd64

Source:

modelmesh-serving/controllers/modelmesh/runtime.go

Lines 345 to 353 in 1b3d30a

	archNodeSelector := corev1.NodeSelectorTerm{
	MatchExpressions: []corev1.NodeSelectorRequirement{
	{
	Key: "kubernetes.io/arch",
	Operator: corev1.NodeSelectorOpIn,
	Values: []string{"amd64"},
	},
	},
	}

Proposed Fix

Support arm64 arch for Node affinity. The modelmesh-runtime-adapter supports amd64 and arm64 as pointed out here.

Modifications

	archNodeSelector := corev1.NodeSelectorTerm{
		MatchExpressions: []corev1.NodeSelectorRequirement{
			{
				Key:      "kubernetes.io/arch",
				Operator: corev1.NodeSelectorOpIn,
				Values:   []string{"amd64", "arm64"},
			},
		},
	}

Result

Successful deployment on arm64 architecture nodes.

Related Issues

• Push multi-arch images #314
• Fix multi-platform build modelmesh#92

[ckadner]

Goes with modelmesh PR kserve/modelmesh#92

[tjohnson31415]

I wonder if it is best practice to always have a NodeSelector for architecture, but that's a separate question from the improvement in this PR.
LGTM!
(the FVT failure looks to be unrelated)

[kserve-oss-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, tjohnson31415

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tjohnson31415]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment