-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump to use autoscaling/v2 #403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafael Vasquez <[email protected]>
rafvasq
requested review from
Jooho and
ckadner
and removed request for
joerunde
July 19, 2023 20:42
rafvasq
changed the title
Bump autoscaling v2beta2 to v2
chore: Bump to use autoscaling/v2
Jul 19, 2023
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
ckadner
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rafvasq
/lgtm
This comment was marked as outdated.
This comment was marked as outdated.
ckadner
pushed a commit
that referenced
this pull request
Jul 24, 2023
The 'autoscaling/v2beta2' API for HPA was deprecated in Kubernetes version 1.23 and is no longer available in Kubernetes version 1.26. Changes: - Update Go code to use 'autoscaling/v2' - Use setup-envtest to force K8s v1.23+ for unit tests to ensure the 'autoscaling/v2' API is available - Update FVT to use Kubernetes version 1.26+ Closes #402 Signed-off-by: Rafael Vasquez <[email protected]> Signed-off-by: Christian Kadner <[email protected]> Co-authored-by: Christian Kadner <[email protected]> (cherry picked from commit ef26b75)
ckadner
pushed a commit
that referenced
this pull request
Jul 24, 2023
The 'autoscaling/v2beta2' API for HPA was deprecated in Kubernetes version 1.23 and is no longer available in Kubernetes version 1.26. Changes: - Update Go code to use 'autoscaling/v2' - Use setup-envtest to force K8s v1.23+ for unit tests to ensure the 'autoscaling/v2' API is available - Update FVT to use Kubernetes version 1.26+ Closes #402 Signed-off-by: Rafael Vasquez <[email protected]> Signed-off-by: Christian Kadner <[email protected]> Co-authored-by: Christian Kadner <[email protected]> (cherry picked from commit ef26b75)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With Kubernetes version 1.23+,
autoscaling/v2beta2
(HPA) was deprecated. In Kubernetes version 1.26+ it is no longer available.Modifications
autoscaling/v2
autoscaling/v2
to be availableResult