Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump to use autoscaling/v2 #403

Merged
merged 7 commits into from
Jul 20, 2023
Merged

chore: Bump to use autoscaling/v2 #403

merged 7 commits into from
Jul 20, 2023

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Jul 19, 2023

Motivation

With Kubernetes version 1.23+, autoscaling/v2beta2 (HPA) was deprecated. In Kubernetes version 1.26+ it is no longer available.

Modifications

  • Update Go code to use autoscaling/v2
  • setup-envtest for unit tests to use Kubernetes version 1.23+ for autoscaling/v2 to be available
  • Update FVT to use Kubernetes version 1.26+

Result

Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq requested review from Jooho and ckadner and removed request for joerunde July 19, 2023 20:42
@rafvasq rafvasq changed the title Bump autoscaling v2beta2 to v2 chore: Bump to use autoscaling/v2 Jul 19, 2023
@rafvasq rafvasq added this to the v0.11.0 milestone Jul 19, 2023
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rafvasq

/lgtm

@kserve-oss-bot

This comment was marked as outdated.

@ckadner ckadner merged commit ef26b75 into kserve:main Jul 20, 2023
@rafvasq rafvasq deleted the update-k8s branch July 20, 2023 16:50
@rafvasq rafvasq added approved and removed approved labels Jul 21, 2023
ckadner pushed a commit that referenced this pull request Jul 24, 2023
The 'autoscaling/v2beta2' API for HPA was deprecated in Kubernetes version 1.23
and is no longer available in Kubernetes version 1.26.

Changes:
- Update Go code to use 'autoscaling/v2'
- Use setup-envtest to force K8s v1.23+ for unit tests to ensure
  the 'autoscaling/v2' API is available
- Update FVT to use Kubernetes version 1.26+

Closes #402

Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Co-authored-by: Christian Kadner <[email protected]>
(cherry picked from commit ef26b75)
ckadner pushed a commit that referenced this pull request Jul 24, 2023
The 'autoscaling/v2beta2' API for HPA was deprecated in Kubernetes version 1.23
and is no longer available in Kubernetes version 1.26.

Changes:
- Update Go code to use 'autoscaling/v2'
- Use setup-envtest to force K8s v1.23+ for unit tests to ensure
  the 'autoscaling/v2' API is available
- Update FVT to use Kubernetes version 1.26+

Closes #402

Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Co-authored-by: Christian Kadner <[email protected]>
(cherry picked from commit ef26b75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deprecated API version for HPA
3 participants