fix: Support request/response parameters #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhill
force-pushed
the
parameters
branch
2 times, most recently
from
abeb267 to
007c7ef
Compare
Motivation Request/response and tensor-level parameter maps were not properly transcoded between the REST and protobuf representations. Modifications - Add custom logic for marshalling/unmarshalling the parameter maps - Extend unit test payloads to cover Result Primitive-type parameters are now supported (the gRPC API does not support complex type valued parameters) Signed-off-by: Nick Hill <[email protected]>
chinhuang007
approved these changes
Oct 12, 2022
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Request/response and tensor-level parameter maps were not properly transcoded between the REST and protobuf representations.
Modifications
Result
Primitive-type parameters are now supported (the gRPC API does not support complex type valued parameters)
Fixes #13