Fix incorrect behavior of cd ../.foo
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cd builtin was removing '.' from directory names when combined with a preceding '../', which caused commands like 'cd ../.local' to become 'cd ../local'. This patch fixes the problem by limiting the extra handling to leading '..'. The bugfix comes from ksh93v- 2013-10-10-alpha, although this version is a shortened patch from Solaris (as ksh93v- refactored a decent amount of the code for the cd builtin). src/cmd/ksh93/bltins/cd_pwd.c: - cd should only check for leading '..', as trying to handle a lone '.' only causes problems. src/cmd/ksh93/tests/builtins.sh: - Add a regression test for this problem based on the test present in ksh93v- 2013-10-10-alpha. Patch from Solaris: https://github.com/oracle/solaris-userland/blob/860d27f/components/ksh93/patches/270-23319761.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cd builtin was removing
.from directory names when combined with a preceding../, which caused commands likecd ../.localto becomecd ../local. This patch fixes the problem by limiting the extra handling to leading... The bugfix comes from ksh93v- 2013-10-10-alpha, although this version is a shortened patch from Solaris (as ksh93v- refactored a decent amount of the code for thecdbuiltin).Patch from Solaris:
https://github.com/oracle/solaris-userland/blob/860d27f/components/ksh93/patches/270-23319761.patch