Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-7893 Add favicon to Swagger UI #4528

Conversation

marychatte
Copy link
Member

@marychatte marychatte force-pushed the marychatte/KTOR-7893-Swagger-UI-Missing-Favicon-while-browsing-the-UI branch from 717819e to 6ef1581 Compare December 3, 2024 15:54
Copy link
Contributor

@stokado stokado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came up with almost the same code, looks good!

@stokado
Copy link
Contributor

stokado commented Dec 4, 2024

One thing, though
Shouldn't license headers be updated with these code changes?

@marychatte marychatte requested a review from osipxd December 4, 2024 14:13
Copy link
Member

@osipxd osipxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge it to 3.1.0-eap

@marychatte marychatte changed the base branch from main to 3.1.0-eap December 4, 2024 14:37
@marychatte marychatte merged commit 3e2ca31 into 3.1.0-eap Dec 5, 2024
14 checks passed
@marychatte marychatte deleted the marychatte/KTOR-7893-Swagger-UI-Missing-Favicon-while-browsing-the-UI branch December 5, 2024 15:12
osipxd pushed a commit that referenced this pull request Dec 6, 2024
osipxd pushed a commit that referenced this pull request Dec 11, 2024
osipxd pushed a commit that referenced this pull request Dec 11, 2024
osipxd pushed a commit that referenced this pull request Dec 12, 2024
osipxd pushed a commit that referenced this pull request Dec 12, 2024
osipxd pushed a commit that referenced this pull request Dec 12, 2024
osipxd pushed a commit that referenced this pull request Dec 19, 2024
Stexxe pushed a commit that referenced this pull request Dec 24, 2024
e5l pushed a commit that referenced this pull request Jan 8, 2025
osipxd pushed a commit that referenced this pull request Jan 8, 2025
osipxd pushed a commit that referenced this pull request Jan 9, 2025
osipxd pushed a commit that referenced this pull request Jan 9, 2025
osipxd pushed a commit that referenced this pull request Jan 9, 2025
osipxd pushed a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants