Add tests for deletion of branch restriction (#148)

This has a the positive side effect of cleaning up after the creation tests (against a live Bitbucket account).
ktrysmt · Jul 18, 2021 · 23fc175 · 23fc175
1 parent 4807eeb
commit 23fc175
Showing 1 changed file with 63 additions and 30 deletions.
diff --git a/tests/branchrestrictions_test.go b/tests/branchrestrictions_test.go
@@ -2,6 +2,7 @@ package tests
 
 import (
 	"os"
+	"strconv"
 	"testing"
 
 	"github.com/ktrysmt/go-bitbucket"
@@ -33,42 +34,74 @@ func setup(t *testing.T) *bitbucket.Client {
 	return c
 }
 
-func TestCreateBranchRestrictionsKindPush(t *testing.T) {
+func TestBranchRestrictionsKindPush(t *testing.T) {
 
 	c := setup(t)
+	var pushRestrictionID int
 
-	opt := &bitbucket.BranchRestrictionsOptions{
-		Owner:    owner,
-		Pattern:  "develop",
-		RepoSlug: repo,
-		Kind:     "push",
-		Users:    []string{user},
-	}
-	res, err := c.Repositories.BranchRestrictions.Create(opt)
-	if err != nil {
-		t.Error(err)
-	}
-	if res.Kind != "push" {
-		t.Error("did not match branchrestriction kind")
-	}
+	t.Run("create", func(t *testing.T) {
+		opt := &bitbucket.BranchRestrictionsOptions{
+			Owner:    owner,
+			Pattern:  "develop",
+			RepoSlug: repo,
+			Kind:     "push",
+			Users:    []string{user},
+		}
+		res, err := c.Repositories.BranchRestrictions.Create(opt)
+		if err != nil {
+			t.Error(err)
+		}
+		if res.Kind != "push" {
+			t.Error("did not match branchrestriction kind")
+		}
+		pushRestrictionID = res.ID
+	})
+
+	t.Run("delete", func(t *testing.T) {
+		opt := &bitbucket.BranchRestrictionsOptions{
+			Owner:    owner,
+			RepoSlug: repo,
+			ID:       strconv.Itoa(pushRestrictionID),
+		}
+		_, err := c.Repositories.BranchRestrictions.Delete(opt)
+		if err != nil {
+			t.Error(err)
+		}
+	})
 }
 
-func TestCreateBranchRestrictionsKindRequirePassingBuilds(t *testing.T) {
+func TestBranchRestrictionsKindRequirePassingBuilds(t *testing.T) {
 
 	c := setup(t)
+	var pushRestrictionID int
 
-	opt := &bitbucket.BranchRestrictionsOptions{
-		Owner:    owner,
-		Pattern:  "master",
-		RepoSlug: repo,
-		Kind:     "require_passing_builds_to_merge",
-		Value:    2,
-	}
-	res, err := c.Repositories.BranchRestrictions.Create(opt)
-	if err != nil {
-		t.Error(err)
-	}
-	if res.Kind != "require_passing_builds_to_merge" {
-		t.Error("did not match branchrestriction kind")
-	}
+	t.Run("create", func(t *testing.T) {
+		opt := &bitbucket.BranchRestrictionsOptions{
+			Owner:    owner,
+			Pattern:  "master",
+			RepoSlug: repo,
+			Kind:     "require_passing_builds_to_merge",
+			Value:    2,
+		}
+		res, err := c.Repositories.BranchRestrictions.Create(opt)
+		if err != nil {
+			t.Error(err)
+		}
+		if res.Kind != "require_passing_builds_to_merge" {
+			t.Error("did not match branchrestriction kind")
+		}
+		pushRestrictionID = res.ID
+	})
+
+	t.Run("delete", func(t *testing.T) {
+		opt := &bitbucket.BranchRestrictionsOptions{
+			Owner:    owner,
+			RepoSlug: repo,
+			ID:       strconv.Itoa(pushRestrictionID),
+		}
+		_, err := c.Repositories.BranchRestrictions.Delete(opt)
+		if err != nil {
+			t.Error(err)
+		}
+	})
 }