-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stored pipeline merge #1128
Stored pipeline merge #1128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nassiharel)
core/api-server/tests/exec-stored.js, line 152 at r1 (raw file):
}; const res2 = await request(optionsGET); expect(res2.body.options.ttl).to.eql(options.body.options.ttl);
add a test to see that none of the options in the stored pipeline aren't deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @yehiyam)
core/api-server/tests/exec-stored.js, line 152 at r1 (raw file):
Previously, yehiyam wrote…
add a test to see that none of the options in the stored pipeline aren't deleted
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
* feat: stored pipeline merge * feat: stored pipeline merge * feat: PR review .... bump version [skip ci]
* feat: stored pipeline merge * feat: stored pipeline merge * feat: PR review .... bump version [skip ci]
This change is