Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored pipeline merge #1128

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Stored pipeline merge #1128

merged 4 commits into from
Feb 3, 2021

Conversation

nassiharel
Copy link
Contributor

@nassiharel nassiharel commented Feb 1, 2021

This change is Reviewable

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nassiharel)


core/api-server/tests/exec-stored.js, line 152 at r1 (raw file):

            };
            const res2 = await request(optionsGET);
            expect(res2.body.options.ttl).to.eql(options.body.options.ttl);

add a test to see that none of the options in the stored pipeline aren't deleted

Copy link
Contributor Author

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @yehiyam)


core/api-server/tests/exec-stored.js, line 152 at r1 (raw file):

Previously, yehiyam wrote…

add a test to see that none of the options in the stored pipeline aren't deleted

Done.

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@nassiharel nassiharel merged commit 021749b into master Feb 3, 2021
@nassiharel nassiharel deleted the stored_pipeline_merge branch February 3, 2021 15:41
hkube-ci pushed a commit that referenced this pull request Feb 3, 2021
* feat: stored pipeline merge

* feat: stored pipeline merge

* feat: PR review .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Feb 3, 2021
* feat: stored pipeline merge

* feat: stored pipeline merge

* feat: PR review .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants