Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support log message from debug algorithm #1342

Merged
merged 4 commits into from
Aug 1, 2021
Merged

Conversation

golanha
Copy link
Member

@golanha golanha commented Jul 27, 2021

This change is Reviewable

@yehiyam
Copy link
Contributor

yehiyam commented Jul 27, 2021

/deploy

@hkube-ci hkube-ci temporarily deployed to dev July 27, 2021 10:15 Inactive
Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @golanha)

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @golanha)

a discussion (no related file):
blocked until nodejs wrapper is published


Copy link
Member Author

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @yehiyam)

a discussion (no related file):

Previously, yehiyam wrote…

blocked until nodejs wrapper is published

Done.


@golanha golanha requested a review from yehiyam July 28, 2021 10:27
Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @golanha)

@golanha golanha merged commit 43e099b into master Aug 1, 2021
@golanha golanha deleted the support_log_debug_algorithm branch August 1, 2021 07:16
hkube-ci pushed a commit that referenced this pull request Aug 1, 2021
* support log message from debug algorithm

* nodejs wrapper version .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Aug 1, 2021
* support log message from debug algorithm

* nodejs wrapper version .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants