Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count instead of jobs list and expose filter by pipeline and tag #1513

Merged
merged 10 commits into from
Feb 8, 2022

Conversation

golanha
Copy link
Member

@golanha golanha commented Feb 1, 2022

This change is Reviewable

Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @golanha)


core/openapi-spec/swagger/paths/managed/list.yaml, line 32 at r1 (raw file):

      schema:
        type: string        
      description: filter by tag            

extra spaces

Code quote:

············

core/openapi-spec/swagger/paths/preferred/list.yaml, line 1 at r1 (raw file):

get:

is this used? It looks the same as paths/preferred/prefered.yaml


core/pipeline-driver-queue/lib/service/preferred-jobs.js, line 118 at r1 (raw file):

    }

    async addPreferredJobs(addedJobs) {

no need for async


core/pipeline-driver-queue/tests/test-preferred-managed.js, line 10 at r1 (raw file):

let producerLib;

describe.only('Preferred and Managed', () => {

remove only

Copy link
Contributor

@nassiharel nassiharel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @golanha)


core/pipeline-driver-queue/lib/service/preferred-jobs.js, line 118 at r2 (raw file):

    }

    async addPreferredJobs(addedJobs) {

There is nothing asynchronous in this function :)

Code quote:

async addPreferredJobs(addedJobs) {

@golanha
Copy link
Member Author

golanha commented Feb 1, 2022

/deploy

@golanha
Copy link
Member Author

golanha commented Feb 1, 2022

/deploy

Copy link
Member Author

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 14 files reviewed, 5 unresolved discussions (waiting on @nassiharel and @yehiyam)


core/openapi-spec/swagger/paths/managed/list.yaml, line 32 at r1 (raw file):

Previously, yehiyam wrote…

extra spaces

Done.

Code quote:

description: filter by tag

core/openapi-spec/swagger/paths/preferred/list.yaml, line 1 at r1 (raw file):

Previously, yehiyam wrote…

is this used? It looks the same as paths/preferred/prefered.yaml

Done.


core/pipeline-driver-queue/lib/service/preferred-jobs.js, line 118 at r1 (raw file):

Previously, yehiyam wrote…

no need for async

Done.

Code quote:

async addPreferredJobs(addedJobs)

core/pipeline-driver-queue/lib/service/preferred-jobs.js, line 118 at r2 (raw file):

Previously, nassiharel (Nassi Harel) wrote…

There is nothing asynchronous in this function :)

Done.


core/pipeline-driver-queue/tests/test-preferred-managed.js, line 10 at r1 (raw file):

Previously, yehiyam wrote…

remove only

Done.

@golanha
Copy link
Member Author

golanha commented Feb 7, 2022

/deploy

@golanha
Copy link
Member Author

golanha commented Feb 7, 2022

/deploy

@hkube-ci hkube-ci temporarily deployed to dev February 7, 2022 08:17 Inactive
@golanha
Copy link
Member Author

golanha commented Feb 7, 2022

/deploy

@hkube-ci hkube-ci temporarily deployed to dev February 7, 2022 10:05 Inactive
@golanha golanha requested a review from yehiyam February 7, 2022 11:40
@yehiyam yehiyam requested a review from nassiharel February 8, 2022 09:17
Copy link
Contributor

@yehiyam yehiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 7 files at r3, 2 of 7 files at r4, 1 of 1 files at r5, 5 of 5 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nassiharel)

@yehiyam yehiyam removed the request for review from nassiharel February 8, 2022 09:22
@golanha golanha merged commit a4a17bf into master Feb 8, 2022
@golanha golanha deleted the preferred_adjutments branch February 8, 2022 09:34
hkube-ci pushed a commit that referenced this pull request Feb 8, 2022
* count instead of jobs list and expose filter by pipeline and tag

* CR

* Include the job of the jobid used in query

* update swagger with firstJobId lastJobId

* toJob -lastJobId

* fix lastJobId

* nfs

* toJob -> lastJobId

Co-authored-by: yehiyam <[email protected]> .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Feb 8, 2022
* count instead of jobs list and expose filter by pipeline and tag

* CR

* Include the job of the jobid used in query

* update swagger with firstJobId lastJobId

* toJob -lastJobId

* fix lastJobId

* nfs

* toJob -> lastJobId

Co-authored-by: yehiyam <[email protected]> .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants