Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add externalid to job #1885

Merged
merged 4 commits into from
Feb 18, 2024
Merged

add externalid to job #1885

merged 4 commits into from
Feb 18, 2024

Conversation

zivglik
Copy link
Contributor

@zivglik zivglik commented Feb 12, 2024

This change is Reviewable

@zivglik
Copy link
Contributor Author

zivglik commented Feb 12, 2024

/deploy dev1

@zivglik
Copy link
Contributor Author

zivglik commented Feb 12, 2024

/deploy dev1

@zivglik
Copy link
Contributor Author

zivglik commented Feb 18, 2024

/deploy dev1

Copy link
Member

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @zivglik)

Copy link
Member

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @zivglik)

@zivglik zivglik merged commit bef4ffb into master Feb 18, 2024
5 checks passed
@zivglik zivglik deleted the add-externalId-to-job branch February 18, 2024 11:27
hkube-ci pushed a commit that referenced this pull request Feb 18, 2024
* add externalid to job

* add externalid in function runstored

* update version db

---------

Co-authored-by: Golan Hallel <[email protected]> .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Feb 18, 2024
* add externalid to job

* add externalid in function runstored

* update version db

---------

Co-authored-by: Golan Hallel <[email protected]> .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants