Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google analytics 4 (GA4): configure CNCF ID #244

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 4, 2024

@fekete-robert fekete-robert self-requested a review June 5, 2024 11:07
@fekete-robert
Copy link
Collaborator

Hi @chalin, many thanks for your help! I usually add the google id only to the production config, to avoid counting local builds, but that's probably not a big issue.

@fekete-robert
Copy link
Collaborator

BTW, do you have a suggested way to show a cookie-consent banner (required because of Google Analytics), or each CNCF project uses its own solution?

@chalin
Copy link
Contributor Author

chalin commented Jun 5, 2024

Hi @chalin, many thanks for your help!

Hi @fekete-robert! Fancy meeting you here 😄

I usually add the google id only to the production config, to avoid counting local builds, but that's probably not a big issue.

Right, GA should only be enabled in production. If you were deploying to Netlify (which might be something you can ask for, cc @nate-double-u to be sure), then we could easily set up GA for production-only deploys via snippet injection.

But, as you probably know, Docsy will only enable GA in a production build, so if your site build is setup properly, all should be good.

@chalin
Copy link
Contributor Author

chalin commented Jun 5, 2024

BTW, do you have a suggested way to show a cookie-consent banner (required because of Google Analytics), or each CNCF project uses its own solution?

I've been working towards a common solution that CNCF projects could adopt. This is still WIP / under investigation. If you feel that this is critical for your project, let me know and I'll see if I can bump up the priority a bit.

@fekete-robert
Copy link
Collaborator

But, as you probably know, Docsy will only enable GA in a production build, so if your site build is setup properly, all should be good.

Oh, right, I forgot about that :)

@fekete-robert
Copy link
Collaborator

I've been working towards a common solution that CNCF projects could adopt. This is still WIP / under investigation. If you feel that this is critical for your project, let me know and I'll see if I can bump up the priority a bit.

No need to rush, I think I have a standalone solution somewhere, I'll add that to the site and change it to the common CNCF solution when it's available.

@fekete-robert fekete-robert merged commit e0229c1 into kube-logging:master Jun 5, 2024
1 check passed
@chalin chalin deleted the patch-1 branch June 5, 2024 20:49
@chalin
Copy link
Contributor Author

chalin commented Jun 5, 2024

I confirm that data is being received:

image

@fekete-robert
Copy link
Collaborator

\o/
Many thanks for the help!

@chalin
Copy link
Contributor Author

chalin commented Jun 5, 2024

FYI: @nate-double-u and I were discussing that after the domain transfer is complete, we'd encourage a migration to Netlify.

@nate-double-u
Copy link

I've opened a new CNCF Service Desk ticket (CNCFSD-2329) to help us track the domain transfer work.

@fekete-robert
Copy link
Collaborator

FYI: @nate-double-u and I were discussing that after the domain transfer is complete, we'd encourage a migration to Netlify.

Sure, we can do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants