-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google analytics 4 (GA4): configure CNCF ID #244
Conversation
Signed-off-by: Patrice Chalin <[email protected]>
Hi @chalin, many thanks for your help! I usually add the google id only to the production config, to avoid counting local builds, but that's probably not a big issue. |
BTW, do you have a suggested way to show a cookie-consent banner (required because of Google Analytics), or each CNCF project uses its own solution? |
Hi @fekete-robert! Fancy meeting you here 😄
Right, GA should only be enabled in production. If you were deploying to Netlify (which might be something you can ask for, cc @nate-double-u to be sure), then we could easily set up GA for production-only deploys via snippet injection. But, as you probably know, Docsy will only enable GA in a production build, so if your site build is setup properly, all should be good. |
I've been working towards a common solution that CNCF projects could adopt. This is still WIP / under investigation. If you feel that this is critical for your project, let me know and I'll see if I can bump up the priority a bit. |
Oh, right, I forgot about that :) |
No need to rush, I think I have a standalone solution somewhere, I'll add that to the site and change it to the common CNCF solution when it's available. |
\o/ |
FYI: @nate-double-u and I were discussing that after the domain transfer is complete, we'd encourage a migration to Netlify. |
I've opened a new CNCF Service Desk ticket (CNCFSD-2329) to help us track the domain transfer work. |
Sure, we can do that |
/cc @nate-double-u