Skip to content

Commit

Permalink
Fix watcher not fully paginating on Init
Browse files Browse the repository at this point in the history
cannot believe i missed this :(
fixes #1524

Signed-off-by: clux <[email protected]>
  • Loading branch information
clux committed Jun 19, 2024
1 parent f553c4e commit b256a53
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions kube-runtime/src/watcher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -499,9 +499,12 @@ where
last_bookmark,
});
}
if let Some(resource_version) = last_bookmark {
// we have drained the last page - move on to next stage
return (Some(Ok(Event::InitDone)), State::InitListed { resource_version });
// check if we need to perform more pages
if continue_token.is_none() {
if let Some(resource_version) = last_bookmark {
// we have drained the last page - move on to next stage
return (Some(Ok(Event::InitDone)), State::InitListed { resource_version });
}
}
let mut lp = wc.to_list_params();
lp.continue_token = continue_token;
Expand Down

0 comments on commit b256a53

Please sign in to comment.