-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate swapping out reqwest for hyper #362
Comments
|
One small request regarding TLS: please expose the |
@jbg Can you open a new issue for |
We are doing a whole lot of manual TLS work ourselves, along with painful re-exporting of feature sets which selects a lot of the same dependencies (which are further re-ordered by #360 where we get a second client for websockets).
It would be interesting to see how feasible it is to just run straight
hyper
withinkube
and see what the fallout of that would be.What does this drop? What does this let us solve better?
I imagine this will force us to make a better encapsulation interface to the Client (to avoid impulses to go down #17), as we are now putting a bunch of parameters within it, making Clone more expensive, even more so after #360.
Most of the dependencies of reqwest we already have anyway; tokio, serde, various tls deps, pin, url, futures*, but there is more. What extra dependencies would this mean we would have to lift into
kube
?ReqwestError
is re-exported in kube::Error due to its nice interface. But looks like Hyper::Error could be usable unless we want to unpack the errors out out of reqwest/hyper entirely.If anyone wants to investigate and/or provide some PoC PRs, this would be appreciated.
The text was updated successfully, but these errors were encountered: