Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Api::default_namespaced #534

Merged
merged 2 commits into from
May 21, 2021
Merged

Conversation

kazk
Copy link
Member

@kazk kazk commented May 21, 2021

This is the cleanest I can think of at the moment.

  • Client gets the default namespace from Config (most users)
  • Client with custom Service defaults to "default", but can specify explicitly with Client::new_with_default_ns(service, default_ns)

Supersedes #413

@clux clux linked an issue May 21, 2021 that may be closed by this pull request
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is much nicer 👍 . I'm not sure we even need to export new_with_default_ns, because if people have the namespace they want out of band, they can probably just use Api::namespaced down the line.

@clux clux merged commit ad5247a into kube-rs:master May 21, 2021
@kazk kazk deleted the add-default-namespaced branch May 21, 2021 20:19
@clux
Copy link
Member

clux commented Jun 5, 2021

released in 0.56, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Api::namespaced should work with default namespace
2 participants