Make raw Client::send method public
#972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the send method public, which can be used to communicate directly with the API server. This can be used to create a proxy server or application-level gateway between localhost and the Kubernetes API server. Signed-off-by: Tiago Castro <[email protected]>
clux
changed the title
Client::send method public
tiagolobocastro
added a commit
to openebs/mayastor-control-plane
that referenced
this pull request
Aug 4, 2022
This consists of a layer7 proxy using the kube-rs text request. Once kube-rs/kube#972 is released we'll tweak this commit to make use of the raw request, thus avoid multiple data conversions. Signed-off-by: Tiago Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the send method public, which can be used to communicate directly with the API server.
This can be used to create a proxy server or application-level gateway between localhost and the
Kubernetes API server.
Signed-off-by: Tiago Castro [email protected]
Motivation
I came across the need for this while trying to write a proxy to a k8s service using the api-server. Essentially what
kubectl proxydoes.Solution
By making the send method public, we can have Service impl that routes requests through the kube-client
sendmethod.Now, I also wonder if we could instead provide a means to access the inner service, which could then simply be plugged in?