Prepare docs for 0.8.0-beta.2 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirshahriar
reviewed
Feb 27, 2018
docs/guides/elasticsearch/README.md
Outdated
|
|
||
| ## Elasticsearch versions supported by KubeDB | ||
|
|
||
| | KubeDB Version | Elasticsearch:2.3 | Elasticsearch:5.6 | | ||
| |----------------|:------------:|:------------:| | ||
| | 0.1.0 - 0.7.0 | ✓ | ✗ | | ||
| | 0.8.0-beta.0 | ✗ | ✓ | | ||
| | 0.8.0-beta.1 | ✗ | ✓ | | ||
| | 0.8.0-beta.2 | ✗ | ✓ | |
| @@ -19,7 +19,7 @@ You have to push the required images from KubeDB's [Docker hub account](https:// | |||
| ```console | |||
| $ export DOCKER_REGISTRY=<your-registry> | |||
|
|
|||
| $ docker pull kubedb/operator:0.8.0-beta.0-4 ; docker tag kubedb/operator:0.8.0-beta.0-4 $DOCKER_REGISTRY/operator:0.8.0-beta.0-4 ; docker push $DOCKER_REGISTRY/operator:0.8.0-beta.0-4 | |||
| $ docker pull kubedb/operator:0.8.0-beta.2-4 ; docker tag kubedb/operator:0.8.0-beta.2-4 $DOCKER_REGISTRY/operator:0.8.0-beta.2-4 ; docker push $DOCKER_REGISTRY/operator:0.8.0-beta.2-4 | |||
There was a problem hiding this comment.
use kubedb/operator:0.8.0-beta.2
| @@ -98,7 +98,7 @@ Now run the command to create this Postgres object: | |||
|
|
|||
| ```console | |||
| $ kubedb create -f https://raw.githubusercontent.com/kubedb/cli/master/docs/examples/postgres/private-registry/pvt-reg-postgres.yaml | |||
There was a problem hiding this comment.
which branch to use? master ? 0.8.0-beta.2?
There was a problem hiding this comment.
need to use 0.8.0-beta.2 branch.
mirshahriar
suggested changes
Feb 27, 2018
| @@ -24,7 +24,7 @@ Standby servers can be either *warm standby* or *hot standby* server. | |||
| A standby server that cannot be connected to until it is promoted to a *master* server is called a *warm standby* server. | |||
| *Standby* servers are by default *warm standby* unless we make them *hot standby*. | |||
|
|
|||
| The following is an example of a Postgres which creates PostgreSQL cluster of three servers. | |||
| The following is an example of a PostgreSQL which creates PostgreSQL cluster of three servers. | |||
There was a problem hiding this comment.
sometimes, Postgres word means CRD Postgres, not PostgreSQL
mirshahriar
reviewed
Feb 27, 2018
| @@ -123,7 +123,7 @@ spec: | |||
| # bucket: kubedb | |||
| ``` | |||
|
|
|||
| ## Update Postgres to enable periodic backups | |||
| ## Update PostgreSQL to enable periodic backups | |||
There was a problem hiding this comment.
like here. Update CRD Postgres
| @@ -334,7 +334,7 @@ spec: | |||
| resume: true | |||
| ``` | |||
|
|
|||
| KubeDB operator will notice that `spec.resume` is set to `true`. It will delete the DormantDatabase object and create a new Postgres using `spec.origin` from DormantDatabase. | |||
| KubeDB operator will notice that `spec.resume` is set to `true`. It will delete the DormantDatabase object and create a new PostgreSQL using `spec.origin` from DormantDatabase. | |||
There was a problem hiding this comment.
most of the cases, Postgres refers to CRD Postgres.
There was a problem hiding this comment.
When it means CRD, we should use Postgres. When it means database, PostgreSQL
There was a problem hiding this comment.
Yes. I have used like this. may be somewhere it is missed
mirshahriar
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.