This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
Update endpoint_ready_test for blueprints #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jlewi
changed the title
|
/assign @Bobgy |
Bobgy
reviewed
Jun 17, 2020
| verify=False) | ||
| #resp = requests.request( | ||
| #"GET", | ||
| #url, |
There was a problem hiding this comment.
nit: shall we get rid of the commented lines?
Fix code to work with IAP using workload identity. * The existing code to get an ID token didn't seem to work with workload identity and didn't match the latest code on the IAP. The latest code appears to use a helper function to get the id token Related to: GoogleCloudPlatform/kubeflow-distribution#51 Create a tekton test for blueprints to verify the endpoint is ready.
|
Thanks @Bobgy ; fixed /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
vpavlin
pushed a commit
to vpavlin/kfctl
that referenced
this pull request
Jul 10, 2020
Fix code to work with IAP using workload identity. * The existing code to get an ID token didn't seem to work with workload identity and didn't match the latest code on the IAP. The latest code appears to use a helper function to get the id token Related to: GoogleCloudPlatform/kubeflow-distribution#51 Create a tekton test for blueprints to verify the endpoint is ready.
vpavlin
pushed a commit
to vpavlin/kfctl
that referenced
this pull request
Jul 20, 2020
Fix code to work with IAP using workload identity. * The existing code to get an ID token didn't seem to work with workload identity and didn't match the latest code on the IAP. The latest code appears to use a helper function to get the id token Related to: GoogleCloudPlatform/kubeflow-distribution#51 Create a tekton test for blueprints to verify the endpoint is ready.
vpavlin
pushed a commit
to vpavlin/kfctl
that referenced
this pull request
Jul 22, 2020
Fix code to work with IAP using workload identity. * The existing code to get an ID token didn't seem to work with workload identity and didn't match the latest code on the IAP. The latest code appears to use a helper function to get the id token Related to: GoogleCloudPlatform/kubeflow-distribution#51 Create a tekton test for blueprints to verify the endpoint is ready.
vpavlin
pushed a commit
to vpavlin/kfctl
that referenced
this pull request
Jul 22, 2020
Fix code to work with IAP using workload identity. * The existing code to get an ID token didn't seem to work with workload identity and didn't match the latest code on the IAP. The latest code appears to use a helper function to get the id token Related to: GoogleCloudPlatform/kubeflow-distribution#51 Create a tekton test for blueprints to verify the endpoint is ready.
crobby
pushed a commit
to crobby/kfctl
that referenced
this pull request
Feb 25, 2021
Fix code to work with IAP using workload identity. * The existing code to get an ID token didn't seem to work with workload identity and didn't match the latest code on the IAP. The latest code appears to use a helper function to get the id token Related to: GoogleCloudPlatform/kubeflow-distribution#51 Create a tekton test for blueprints to verify the endpoint is ready.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multi-package namespaces for python.
Fix code to work with IAP using workload identity.
identity and didn't match the latest code on the IAP. The latest
code appears to use a helper function to get the id token
Related to: GoogleCloudPlatform/kubeflow-distribution#51 Create a tekton test for blueprints
to verify the endpoint is ready.