This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
Fix kf_is_ready_test #372
Merged
Fix kf_is_ready_test #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* istio_egressgateway is no longer deployed so need to remove it from list of deployments we check for; it doesn't seem to be required to enable outbound internet access. * Split up the kf_is_ready_test into more focused tests * Related to GoogleCloudPlatform/kubeflow-distribution#73
|
This change is |
|
Looks like unittests failed because we are out of disk space on our NFS mount. |
|
/lgtm |
…ofile https://istio.io/latest/docs/tasks/policy-enforcement/enabling-policy/ * This appears to be different from security and authorization.
|
/test all |
|
No specific error; looks like a timeout downloading go modules |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
vpavlin
pushed a commit
to vpavlin/kfctl
that referenced
this pull request
Jul 10, 2020
* Fix kf_is_ready_test * istio_egressgateway is no longer deployed so need to remove it from list of deployments we check for; it doesn't seem to be required to enable outbound internet access. * Split up the kf_is_ready_test into more focused tests * Related to GoogleCloudPlatform/kubeflow-distribution#73 * * istio-policy is deprecated and no longer included in the default profile https://istio.io/latest/docs/tasks/policy-enforcement/enabling-policy/ * This appears to be different from security and authorization.
vpavlin
pushed a commit
to vpavlin/kfctl
that referenced
this pull request
Jul 22, 2020
* Fix kf_is_ready_test * istio_egressgateway is no longer deployed so need to remove it from list of deployments we check for; it doesn't seem to be required to enable outbound internet access. * Split up the kf_is_ready_test into more focused tests * Related to GoogleCloudPlatform/kubeflow-distribution#73 * * istio-policy is deprecated and no longer included in the default profile https://istio.io/latest/docs/tasks/policy-enforcement/enabling-policy/ * This appears to be different from security and authorization.
vpavlin
pushed a commit
to vpavlin/kfctl
that referenced
this pull request
Jul 22, 2020
* Fix kf_is_ready_test * istio_egressgateway is no longer deployed so need to remove it from list of deployments we check for; it doesn't seem to be required to enable outbound internet access. * Split up the kf_is_ready_test into more focused tests * Related to GoogleCloudPlatform/kubeflow-distribution#73 * * istio-policy is deprecated and no longer included in the default profile https://istio.io/latest/docs/tasks/policy-enforcement/enabling-policy/ * This appears to be different from security and authorization.
crobby
pushed a commit
to crobby/kfctl
that referenced
this pull request
Feb 25, 2021
* Fix kf_is_ready_test * istio_egressgateway is no longer deployed so need to remove it from list of deployments we check for; it doesn't seem to be required to enable outbound internet access. * Split up the kf_is_ready_test into more focused tests * Related to GoogleCloudPlatform/kubeflow-distribution#73 * * istio-policy is deprecated and no longer included in the default profile https://istio.io/latest/docs/tasks/policy-enforcement/enabling-policy/ * This appears to be different from security and authorization.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
istio_egressgateway is no longer deployed so need to remove it from
list of deployments we check for; it doesn't seem to be required
to enable outbound internet access.
Split up the kf_is_ready_test into more focused tests
Related to istio-ready test is failing - missing deployment istio-egressgateway GoogleCloudPlatform/kubeflow-distribution#73