This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
Add an explicit platform parameter to the kf_is_ready_test.py #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For GCP blueprints we no longer provide a KFDef file so we need some other mechanism to tell it that the test is running on GCP and to invoke GCP specific tests. Related to GoogleCloudPlatform/kubeflow-distribution#74 and GoogleCloudPlatform/kubeflow-distribution#73 * ISTIO telemetry, tracing, and prometheus are no longer included in the default profile.
|
This change is |
|
/assign @Bobgy |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crobby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vpavlin
pushed a commit
to vpavlin/kfctl
that referenced
this pull request
Jul 10, 2020
…ow#374) * For GCP blueprints we no longer provide a KFDef file so we need some other mechanism to tell it that the test is running on GCP and to invoke GCP specific tests. Related to GoogleCloudPlatform/kubeflow-distribution#74 and GoogleCloudPlatform/kubeflow-distribution#73 * ISTIO telemetry, tracing, and prometheus are no longer included in the default profile.
vpavlin
pushed a commit
to vpavlin/kfctl
that referenced
this pull request
Jul 22, 2020
…ow#374) * For GCP blueprints we no longer provide a KFDef file so we need some other mechanism to tell it that the test is running on GCP and to invoke GCP specific tests. Related to GoogleCloudPlatform/kubeflow-distribution#74 and GoogleCloudPlatform/kubeflow-distribution#73 * ISTIO telemetry, tracing, and prometheus are no longer included in the default profile.
vpavlin
pushed a commit
to vpavlin/kfctl
that referenced
this pull request
Jul 22, 2020
…ow#374) * For GCP blueprints we no longer provide a KFDef file so we need some other mechanism to tell it that the test is running on GCP and to invoke GCP specific tests. Related to GoogleCloudPlatform/kubeflow-distribution#74 and GoogleCloudPlatform/kubeflow-distribution#73 * ISTIO telemetry, tracing, and prometheus are no longer included in the default profile.
crobby
pushed a commit
to crobby/kfctl
that referenced
this pull request
Feb 25, 2021
…ow#374) * For GCP blueprints we no longer provide a KFDef file so we need some other mechanism to tell it that the test is running on GCP and to invoke GCP specific tests. Related to GoogleCloudPlatform/kubeflow-distribution#74 and GoogleCloudPlatform/kubeflow-distribution#73 * ISTIO telemetry, tracing, and prometheus are no longer included in the default profile.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
other mechanism to tell it that the test is running on GCP and
to invoke GCP specific tests.
Related to GoogleCloudPlatform/kubeflow-distribution#74 and GoogleCloudPlatform/kubeflow-distribution#73
the default profile.