Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Fix build error for int to string conversion (#396) #397

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

pinkavaj
Copy link
Contributor

Fixes build issue

pkg/kfapp/aws/aws.go:564:74: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)

Fixed as suggested, sinc the result should be string with the actual port number.

@google-cla
Copy link

google-cla bot commented Aug 14, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from pdmack and Tomcli August 14, 2020 08:05
@k8s-ci-robot
Copy link
Contributor

Hi @pinkavaj. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pinkavaj
Copy link
Contributor Author

@googlebot I signed it!

@pinkavaj
Copy link
Contributor Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

Googlers: Go here for more info.

@googlebot I signed it!

@Jeffwan
Copy link
Member

Jeffwan commented Aug 20, 2020

/ok-to-test

@Jeffwan
Copy link
Member

Jeffwan commented Aug 20, 2020

@pinkavaj What's your golang version? We didn't see this issue in the past

@pinkavaj
Copy link
Contributor Author

@pinkavaj What's your golang version? We didn't see this issue in the past

go version go1.15 linux/amd64

@Jeffwan
Copy link
Member

Jeffwan commented Aug 20, 2020

I see. That's probably the reason. Seems this is an backward incompatible change after checking golang/go#32479 and prometheus/prometheus#7706

We can make this change for higher go versions. Thanks for contributing!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 829253f into kubeflow:master Aug 20, 2020
crobby pushed a commit to crobby/kfctl that referenced this pull request Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants