-
Notifications
You must be signed in to change notification settings - Fork 137
Fix build error for int to string conversion (#396) #397
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @pinkavaj. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
@googlebot I signed it! |
/ok-to-test |
@pinkavaj What's your golang version? We didn't see this issue in the past |
go version go1.15 linux/amd64 |
I see. That's probably the reason. Seems this is an backward incompatible change after checking golang/go#32479 and prometheus/prometheus#7706 We can make this change for higher go versions. Thanks for contributing! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#397) Co-authored-by: Jiri Pinkava <[email protected]>
Fixes build issue
Fixed as suggested, sinc the result should be string with the actual port number.