Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

fix: dump generate invalid yaml #413

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

jtherin
Copy link
Contributor

@jtherin jtherin commented Sep 21, 2020

Fixes #412

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @jtherin. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@PatrickXYS PatrickXYS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtherin Thanks for contributing!

I left a few comments

pkg/kfapp/kustomize/kustomize.go Outdated Show resolved Hide resolved
@PatrickXYS
Copy link
Member

/ok-to-test

@PatrickXYS
Copy link
Member

/lgtm
/approve

@PatrickXYS
Copy link
Member

/assign @adrian555

@crobby
Copy link
Member

crobby commented Oct 6, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crobby, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4c15951 into kubeflow:master Oct 6, 2020
@jtherin jtherin deleted the fixdump branch October 6, 2020 20:07
crobby pushed a commit to crobby/kfctl that referenced this pull request Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dumping generate invalid yaml
6 participants