Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Fixed the default output to point to 1.2 instead of 1.0 #453

Merged

Conversation

naveensrinivasan
Copy link
Member

Fixes the default config value.

#451

@aws-kf-ci-bot
Copy link

Hi @naveensrinivasan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Member

Jeffwan commented Nov 19, 2020

It would be great to use auto cherry-pick scripts later

@Jeffwan
Copy link
Member

Jeffwan commented Nov 19, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, naveensrinivasan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 798a9a6 into kubeflow:v1.2-branch Nov 19, 2020
@naveensrinivasan
Copy link
Member Author

It would be great to use auto cherry-pick scripts later

@Jeffwan Could you please point me to the instructions?

@Jeffwan
Copy link
Member

Jeffwan commented Nov 19, 2020

@naveensrinivasan check this one https://github.com/kubeflow/kubeflow/blob/master/hack/cherry-picks.md

kubernetes community has one as well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants